OTA-1678: remove image-registry exceptions on operator state transitions#30755
OTA-1678: remove image-registry exceptions on operator state transitions#30755tjungblu wants to merge 1 commit intoopenshift:mainfrom
Conversation
Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@tjungblu: This pull request references OTA-1678 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold waiting for openshift/cluster-image-registry-operator#1286 to get merged and go into nightlies |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tjungblu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Scheduling required tests: |
|
@tjungblu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
please consider also openshift/cluster-image-registry-operator#1293 |
hongkailiu
left a comment
hongkailiu
left a comment
There was a problem hiding this comment.
- https://issues.redhat.com/browse/OCPBUGS-66213 is still NEW.
- https://issues.redhat.com/browse/OCPBUGS-66225 is VERIFIED but i was expecting there will a new one to replace it. See the comment.
- https://issues.redhat.com/browse/OCPBUGS-62626 is not yet Closed.
If we remove those exception before their fixes get in, the failure of the test cases will block the OCP release procedure.
| // image-registry can become unavailable when it only has one replica, this is expected behavior | ||
| // and the linked OCPBUGS ticket is closed as won't fix. | ||
| if replicaCount, _ := checkReplicas("openshift-image-registry", operator, clientConfig); replicaCount == 1 { | ||
| return "https://issues.redhat.com/browse/OCPBUGS-22382" |
There was a problem hiding this comment.
Is it one replica on any platform other than vsphere?
I am curious because it seems alright on non-vsphere clusters.
4 participants
This also removes the current vsphere logic, as the single-replica deployment can't have availability guarantees in all SKUs, not just vsphere.